-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: remove non-existant methods from docs #30346
Closed
SimonSchick
wants to merge
1
commit into
nodejs:master
from
SimonSchick:docs/remove-dead-inspector-methods
Closed
console: remove non-existant methods from docs #30346
SimonSchick
wants to merge
1
commit into
nodejs:master
from
SimonSchick:docs/remove-dead-inspector-methods
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
console
Issues and PRs related to the console subsystem.
doc
Issues and PRs related to the documentations.
labels
Nov 10, 2019
SimonSchick
force-pushed
the
docs/remove-dead-inspector-methods
branch
from
November 10, 2019 07:10
22703ab
to
1bceb10
Compare
lpinca
approved these changes
Nov 10, 2019
SimonSchick
force-pushed
the
docs/remove-dead-inspector-methods
branch
2 times, most recently
from
November 10, 2019 07:58
df39117
to
8d29657
Compare
Fixed lint and commit message. |
SimonSchick
changed the title
docs, lib: remove non-existant methods
console: remove non-existant methods from docs
Nov 10, 2019
@SimonSchick I think |
Ah, I tried to use |
SimonSchick
force-pushed
the
docs/remove-dead-inspector-methods
branch
from
November 10, 2019 08:43
8d29657
to
5e7d211
Compare
trivikr
approved these changes
Nov 10, 2019
danbev
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 12, 2019
danbev
pushed a commit
that referenced
this pull request
Nov 13, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Landed in 0e964a7. |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
9 tasks
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30346 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
console
Issues and PRs related to the console subsystem.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
It seems these methods are not present anymore, not even with
--inspect
so I propose removing these docs.