Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-benchmark-cluster #30342

Merged
merged 0 commits into from
Nov 9, 2019
Merged

test: fix test-benchmark-cluster #30342

merged 0 commits into from
Nov 9, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 9, 2019

test-benchmark-cluster needs to account for an option added in 973f324.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 9, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26495/

@Trott
Copy link
Member Author

Trott commented Nov 9, 2019

This fixes the nightly node-daily-master CI job, so I'd like to fast-track it. 👍 if you're a Collaborator and you approve.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 9, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 9, 2019
@Trott
Copy link
Member Author

Trott commented Nov 9, 2019

Landed in acd35d9

@Trott Trott closed this Nov 9, 2019
@Trott Trott reopened this Nov 9, 2019
@Trott Trott merged commit acd35d9 into nodejs:master Nov 9, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@Trott @MylesBorins
test: fix test-benchmark-cluster
308f5e4 
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@Trott @targos
test: fix test-benchmark-cluster
4acd3c3 
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott @MylesBorins
test: fix test-benchmark-cluster
5b42857 
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
@Trott Trott deleted the fix-cluster-test branch January 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @lpinca @cjihrig @ZYSzys