Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-http-dump-req-when-res-ends as flaky on windows #30316

Closed
wants to merge 1 commit into from
Closed

test: mark test-http-dump-req-when-res-ends as flaky on windows #30316

wants to merge 1 commit into from

Conversation

AshCripps
Copy link
Member

Refs. #30011

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26409/

@sam-github sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2019
@sam-github
Copy link
Contributor

Can I fast-track this to maximize greenness of CI?

@danbev
Copy link
Contributor

danbev commented Nov 11, 2019

Landed in 8ac771b.

@danbev danbev closed this Nov 11, 2019
danbev pushed a commit that referenced this pull request Nov 11, 2019
@danbev
test: mark test-http-dump-req-when-res-ends as flaky on windows
8ac771b 
PR-URL: #30316
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@MylesBorins
test: mark test-http-dump-req-when-res-ends as flaky on windows
ea0c1a6 
PR-URL: #30316
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@AshCripps AshCripps mentioned this pull request Nov 19, 2019
Closed
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@targos
test: mark test-http-dump-req-when-res-ends as flaky on windows
4f91459 
PR-URL: #30316
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@MylesBorins
test: mark test-http-dump-req-when-res-ends as flaky on windows
5e2848d 
PR-URL: #30316
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AshCripps @nodejs-github-bot @sam-github @danbev @targos @cjihrig @BethGriggs @trivikr