http: destruct primordials in lib/_http_server.js #30315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destruct primordials for better perfomance
addaleax
approved these changes
Nov 6, 2019
cjihrig
approved these changes
Nov 6, 2019
ChALkeR
added
the
code-and-learn
|
Could use |
trivikr
approved these changes
Nov 6, 2019
BridgeAR
approved these changes
Nov 6, 2019
ChALkeR
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
The commit message should be fixed, the first line is too long.
Specifically:
- The first line should contain a short description of the change (preferably 50 characters or less, and no more than 72 characters)
- Keep the second line blank.
- Wrap all other lines at 72 columns (except for long URLs).
@artmaks That could be fixed while landing, but it would also help if you would amend the commit message to conform to those rules and force-push =).
gireeshpunathil
approved these changes
Nov 7, 2019
gireeshpunathil
added
the
author ready
|
Landed in 0d28527 |
targos
pushed a commit
that referenced
this pull request
Nov 22, 2019
PR-URL: #30315 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30315 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30315 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30315 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destruct primordials for better perfomance
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes