Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Negative case for fs Dir class initialisation without handler #30313

Closed
wants to merge 1 commit into from
Closed

test: Negative case for fs Dir class initialisation without handler #30313

wants to merge 1 commit into from

Conversation

Di9
Copy link

@Di9 Di9 commented Nov 6, 2019 •
edited
Loading

Covering the case when init Dir class without passing handler to constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
@ChALkeR ChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2019
trivikr
trivikr approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch which this PR covers can be viewed here https://coverage.nodejs.org/coverage-b6201abacf36cc49/lib/internal/fs/dir.js.html#L39

@Di9 Di9 force-pushed the test-fs-dir-add branch 2 times, most recently from 67d5ee4 to f08b7fd Compare November 7, 2019 07:40
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26434/

test: dir class initialisation w/o handler
acdbc6c 
Covering the case when init Dir class without passing
handle paramd to constructor.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26583/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27033/

@gireeshpunathil
Copy link
Member

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

the windows failure parallel/test-inspector-wait-for-connection is known as in #30619

the windows failure sequential/test-inspector-contexts is known as in #30519

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
@gireeshpunathil
test: dir class initialisation w/o handler
8c41b19 
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 8c41b19.

thanks for the contribution!

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@addaleax
test: dir class initialisation w/o handler
d4b6170 
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
@targos
test: dir class initialisation w/o handler
c5e3816 
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@MylesBorins
test: dir class initialisation w/o handler
12ef7d9 
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Di9 @nodejs-github-bot @gireeshpunathil @jasnell @lpinca @cjihrig @devnexen @BridgeAR @trivikr @ChALkeR