Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update npm to 6.12.1 #30164

Closed
wants to merge 1 commit into from
Closed

deps: update npm to 6.12.1 #30164

wants to merge 1 commit into from

Conversation

mikemimik
Copy link

6.12.1 (2019-10-29)

BUG FIXES

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 29, 2019
@Trott Trott mentioned this pull request Oct 29, 2019
Closed
@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 29, 2019
@MylesBorins
Copy link
Contributor

This fixes the node.js 13 bug. I think we should fast track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26243/

MylesBorins
MylesBorins approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ljharb ljharb mentioned this pull request Oct 29, 2019
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26245/

@Trott
Copy link
Member

Trott commented Oct 29, 2019

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2080/

@MylesBorins
Copy link
Contributor

Landed in efe31e7

MylesBorins pushed a commit that referenced this pull request Oct 30, 2019
@MylesBorins
deps: update npm to 6.12.1
efe31e7 
PR-URL: #30164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Nov 5, 2019
@targos
deps: update npm to 6.12.1
e312448 
PR-URL: #30164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@targos
deps: update npm to 6.12.1
c3b09c2 
PR-URL: #30164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@targos
deps: update npm to 6.12.1
c93475e 
PR-URL: #30164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@targos
deps: update npm to 6.12.1
a0f17a7 
PR-URL: #30164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 10, 2019
@Trott Trott mentioned this pull request Nov 10, 2019
Closed
targos pushed a commit that referenced this pull request Nov 11, 2019
@targos
deps: update npm to 6.12.1
b88314f 
PR-URL: #30164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikemimik @MylesBorins @nodejs-github-bot @Trott @addaleax @cjihrig @gengjiawen