Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: linkify .fork() in cluster documentation #30163

Closed
wants to merge 1 commit into from
Closed

doc: linkify .fork() in cluster documentation #30163

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Oct 29, 2019
trivikr
trivikr requested changes Oct 29, 2019
View reviewed changes
doc/api/cluster.md Show resolved Hide resolved
@trivikr
Copy link
Member

trivikr commented Oct 31, 2019

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4022/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2019
addaleax added a commit that referenced this pull request Nov 1, 2019
@addaleax
doc: linkify .fork() in cluster documentation
b4d7a31 
PR-URL: #30163
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@addaleax
Copy link
Member Author

addaleax commented Nov 1, 2019

Landed in b4d7a31

@addaleax addaleax closed this Nov 1, 2019
@addaleax addaleax deleted the cluster-doc-linkify branch November 1, 2019 12:00
trivikr added a commit to trivikr/node that referenced this pull request Nov 1, 2019
@trivikr
doc: linkify .setupMaster() in cluster doc
f4f842b 
Refs: nodejs#30163
@trivikr trivikr mentioned this pull request Nov 1, 2019
Closed
2 tasks
gireeshpunathil pushed a commit that referenced this pull request Nov 3, 2019
@trivikr @gireeshpunathil
doc: linkify .setupMaster() in cluster doc
772ce0b 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 5, 2019
@addaleax @targos
doc: linkify .fork() in cluster documentation
f8fb2c0 
PR-URL: #30163
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 5, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
201a60e 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@addaleax @targos
doc: linkify .fork() in cluster documentation
a512f19 
PR-URL: #30163
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 8, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
fd05442 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@addaleax @targos
doc: linkify .fork() in cluster documentation
5714e7e 
PR-URL: #30163
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
d64a91c 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@addaleax @targos
doc: linkify .fork() in cluster documentation
29fa1ee 
PR-URL: #30163
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
e5b2a8a 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@addaleax @targos
doc: linkify .fork() in cluster documentation
d7bfc6c 
PR-URL: #30163
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2019
@trivikr @targos
doc: linkify .setupMaster() in cluster doc
b159b91 
Refs: #30163
PR-URL: #30204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@devnexen devnexen devnexen approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @trivikr @lpinca @cjihrig @tniessen @devnexen @nodejs-github-bot