-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: git rm -r tools/v8_gypfiles/broken #30149
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested review from
sam-github,
bnoordhuis,
Trott,
targos and
richardlau
October 27, 2019 14:50
targos
approved these changes
Oct 27, 2019
cclauss
added
the
python
PRs and issues that require attention from people who are familiar with Python.
label
Oct 27, 2019
bnoordhuis
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
richardlau
approved these changes
Oct 28, 2019
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 28, 2019
cjihrig
approved these changes
Oct 28, 2019
lpinca
approved these changes
Oct 28, 2019
gengjiawen
approved these changes
Oct 29, 2019
cclauss
added a commit
that referenced
this pull request
Oct 31, 2019
PR-URL: #30149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Landed in 1f080fc |
targos
pushed a commit
that referenced
this pull request
Nov 5, 2019
PR-URL: #30149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
PR-URL: #30149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
PR-URL: #30149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
PR-URL: #30149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2019
PR-URL: #30149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
python
PRs and issues that require attention from people who are familiar with Python.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by #30143 the tools/v8_gypfiles/broken has at least three
files that contain Python 3 syntax errors or call removed Python builtins.
https://travis-ci.com/nodejs/node/jobs/249935565#L267-L275
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes