Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove incorrect and outdated example #30138

Closed
wants to merge 1 commit into from
Closed

doc: remove incorrect and outdated example #30138

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This description and example are only relevant for versions older than 6.0, all of which have been EOL for a while now. Also, e03ee71 changed the example code to use an arrow function, effectively breaking it since arguments.length is not available in arrow functions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Oct 26, 2019
@tniessen
Copy link
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4015/

@tniessen
Copy link
Member Author

Given the quick reaction, please add 👍 here to approve fast-tracking.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 28, 2019
tniessen added a commit that referenced this pull request Oct 28, 2019
@tniessen
doc: remove incorrect and outdated example
5783ed7 
PR-URL: #30138
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@tniessen
Copy link
Member Author

Landed in 5783ed7, thanks for reviewing!

@tniessen tniessen closed this Oct 28, 2019
targos pushed a commit that referenced this pull request Oct 28, 2019
@tniessen @targos
doc: remove incorrect and outdated example
e4ab6fc 
PR-URL: #30138
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@tniessen @targos
doc: remove incorrect and outdated example
6686abd 
PR-URL: #30138
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@tniessen @targos
doc: remove incorrect and outdated example
8c555cf 
PR-URL: #30138
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@tniessen @targos
doc: remove incorrect and outdated example
998f71e 
PR-URL: #30138
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@tniessen @targos
doc: remove incorrect and outdated example
28db999 
PR-URL: #30138
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@tniessen tniessen deleted the doc-remove-incorrect-outdated-example branch January 23, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @fhinkel @Trott @addaleax @lpinca @cjihrig @trivikr @nodejs-github-bot