Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 6.6.0 #30123

Merged
merged 1 commit into from
Oct 28, 2019
Merged

tools: update ESLint to 6.6.0 #30123

merged 1 commit into from
Oct 28, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 25, 2019

Update ESLint to 6.6.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 25, 2019
@lpinca
Copy link
Member

lpinca commented Oct 25, 2019

RSLGTM.

Trott
Trott approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

ZYSzys
ZYSzys approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2019
trivikr
trivikr approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
Copy link
Member

Trott commented Oct 26, 2019 •
edited by cjihrig
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4010/ 💚

@cjihrig
tools: update ESLint to 6.6.0
511f67b 
Update ESLint to 6.6.0

PR-URL: nodejs#30123
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@cjihrig cjihrig merged commit 511f67b into nodejs:master Oct 28, 2019
@cjihrig cjihrig deleted the eslint branch October 28, 2019 13:52
targos pushed a commit that referenced this pull request Nov 5, 2019
@cjihrig @targos
tools: update ESLint to 6.6.0
d549a34 
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cjihrig @targos
tools: update ESLint to 6.6.0
69287ad 
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cjihrig @targos
tools: update ESLint to 6.6.0
e3496e0 
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cjihrig @targos
tools: update ESLint to 6.6.0
6a86d06 
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cjihrig @targos
tools: update ESLint to 6.6.0
375f349 
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Dec 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @lpinca @Trott @trivikr @ZYSzys @nodejs-github-bot