Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: only emit after for AsyncResource if stack not empty #30087

Closed
wants to merge 1 commit into from
Closed

async_hooks: only emit after for AsyncResource if stack not empty #30087

wants to merge 1 commit into from

Commits on Oct 23, 2019

  1. async_hooks: only emit after for AsyncResource if stack not empty 

    We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: nodejs#30080
    @addaleax
    addaleax committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    dddc895 View commit details
    Browse the repository at this point in the history