Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: claim NODE_MODULE_VERSION=80 for Electron 9 #30052

Closed
wants to merge 1 commit into from
Closed

doc: claim NODE_MODULE_VERSION=80 for Electron 9 #30052

wants to merge 1 commit into from

Conversation

MarshallOfSound
Copy link
Member

As in title, just claiming our next number

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 21, 2019
richardlau
richardlau approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please coordinate with @targos as #30020 is also claiming 80.

@MarshallOfSound
Copy link
Member Author

@targos Happy to take whichever number but I feel as though this PR is gonna land first. Just lemme know which number you're ok with 👍

@targos
Copy link
Member

targos commented Oct 22, 2019

#30020 is going to land much later, you can have 80.

@targos
Copy link
Member

targos commented Oct 24, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4005/

targos pushed a commit that referenced this pull request Oct 27, 2019
@MarshallOfSound @targos
doc: claim NODE_MODULE_VERSION=80 for Electron 9
3a90fcf 
PR-URL: #30052
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member

targos commented Oct 27, 2019 •
edited
Loading

Landed in 3a90fcf

@targos targos closed this Oct 27, 2019
targos pushed a commit that referenced this pull request Oct 28, 2019
@MarshallOfSound @targos
doc: claim NODE_MODULE_VERSION=80 for Electron 9
d91d270 
PR-URL: #30052
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
@pmahend1
Copy link

So what does NODE_MODULE_VERSION corresponds to ? I used NodeJs 13.1.0 for building electron-edge-js , and it says that is NODE_MODULE_VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@MarshallOfSound @targos @pmahend1 @jasnell @lpinca @cjihrig @devnexen @richardlau @BethGriggs @nodejs-github-bot