-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove uses of deprecated wasm TransferrableModule #30026
src: remove uses of deprecated wasm TransferrableModule #30026
Conversation
|
@targos Yeah, I’ve just edited the description to reflect that this needs to land after V8 7.9 :) |
WasmModuleObject::TransferrableModule is deprecated and will be removed in V8 v8.0. Replace all uses by CompiledWasmModule. Refs: v8#101
2288b08
to
c3440a8
Compare
WasmModuleObject::TransferrableModule is deprecated and will be removed in V8 v8.0. Replace all uses by CompiledWasmModule. Refs: v8#101 PR-URL: #30026 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]>
Landed in 69f19f4 |
@addaleax |
This lands cleanly after applying V8 7.9 but it does not compile. I guess we have to wait with this until V8 8.0?
|
@BridgeAR This likely won’t work on v13.x the way we are doing the 7.9 backport, but it also doesn’t really have to land on v13.x anyway. I’ll add the dont-land label. |
(Blocked on #30020)
WasmModuleObject::TransferrableModule is deprecated and will be removed
in V8 v8.0. Replace all uses by CompiledWasmModule.
Refs: v8#101
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes