Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix fs benchmark test #29967

Closed
wants to merge 0 commits into from
Closed

test: fix fs benchmark test #29967

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 14, 2019

Add missing option "mode". Alphabetize options for easier maintenance.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 14, 2019
@Trott
Copy link
Member Author

Trott commented Oct 14, 2019

I'd like to fast-track this to fix nightly CI.

Example: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9482/testReport/junit/(root)/test/benchmark_test_benchmark_fs/

Please 👍 here to approve if you're a collaborator. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Oct 14, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3991/ (benchmark tests are not run in regular CI)

Trott added a commit to Trott/io.js that referenced this pull request Oct 14, 2019
@Trott
test: fix fs benchmark test
7991b57 
Add missing option "mode". Alphabetize options for easier maintenance.

PR-URL: nodejs#29967
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@Trott
Copy link
Member Author

Trott commented Oct 14, 2019

Landed in 7991b57

@Trott Trott closed this Oct 14, 2019
@Trott Trott reopened this Oct 14, 2019
@Trott Trott closed this Oct 14, 2019
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@Trott @targos
test: fix fs benchmark test
3326ba0 
Add missing option "mode". Alphabetize options for easier maintenance.

PR-URL: #29967
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@Trott @targos
test: fix fs benchmark test
aec8e77 
Add missing option "mode". Alphabetize options for easier maintenance.

PR-URL: #29967
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
@Trott Trott deleted the fix-benchmark-tests branch January 13, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @addaleax @cjihrig @devnexen