Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix --enable-source-maps flag in v12.12.0 changelog #29960

Closed
wants to merge 1 commit into from
Closed

doc: fix --enable-source-maps flag in v12.12.0 changelog #29960

wants to merge 1 commit into from

Conversation

TheUnlocked
Copy link
Contributor

Resolves #29959

@TheUnlocked
Resolves nodejs#29959
c3eea4c 
Corrects "--source-map-support" to "--enable-source-maps"
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 14, 2019
@Trott Trott requested a review from bcoe October 14, 2019 02:07
@Trott Trott mentioned this pull request Oct 14, 2019
Merged
@BridgeAR BridgeAR changed the title Correct "--source-map-support" to "--enable-source-maps" in v12.12.0 changelog doc: fix --enable-source-maps flag in v12.12.0 changelog Oct 14, 2019
@BridgeAR
Copy link
Member

Please upvote to fast-track.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2019
@addaleax
Copy link
Member

Landed in c625039

@addaleax addaleax closed this Oct 14, 2019
addaleax pushed a commit that referenced this pull request Oct 14, 2019
@TheUnlocked @addaleax
doc: fix --enable-source-maps flag in v12.12.0 changelog
c625039 
Corrects "--source-map-support" to "--enable-source-maps".

Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Oct 14, 2019
@TheUnlocked @targos
doc: fix --enable-source-maps flag in v12.12.0 changelog
1dde617 
Corrects "--source-map-support" to "--enable-source-maps".

Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Oct 15, 2019
Merged
@addaleax addaleax added the source maps Issues and PRs related to source map support. label Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. source maps Issues and PRs related to source map support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CHANGELOG_V12 - wrong flag listed
7 participants
@TheUnlocked @BridgeAR @addaleax @Trott @targos @BethGriggs @nodejs-github-bot