tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE #29956
Conversation
devsnek
added
test
|
Collaborators, 👍 here to fast-track. |
Trott
added
the
author ready
PR-URL: nodejs#29956 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Fast-tracking requires two approvals but this only received one. |
(Also: Totally reasonable to not know all the rules, so I'm kinda "eh, whatever" about this sort of thing. IMO, if we want all our rules followed, we need to either simplify them or automate them--maybe both. I hope to try to get a commit queue initiative restarted at Interactive this year, so hopefully we'll get that automation....) |
|
@Trott oh i thought richard counted, since he approved after i added the label. apologies. |
Yeah, that stands to reason. Our guide is explicit about a fast-track approval needing to be explicitly approved in addition to approving the change, but I wouldn't be surprised if that often doesn't happen. |
PR-URL: #29956 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #29956 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
running the repl tests will fail because node will use the system's NODE_REPL_EXTERNAL_MODULE variable. This ensures the built-in repl is used.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes