Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: nest code fence under unordered list #29915

Closed
wants to merge 2 commits into from

Conversation

nschonni
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

When it isn't nested, a new unordered list is created for the next item
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 10, 2019
@BridgeAR
Copy link
Member

@nschonni thank you for looking closely into the documentation formatting!

@nschonni
Copy link
Member Author

No problem, just see what the gaps are between the Remark-lint preset and Markdownlint :)

@Trott
Copy link
Member

Trott commented Oct 10, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2019
Trott pushed a commit that referenced this pull request Oct 13, 2019
PR-URL: #29915
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Trott pushed a commit that referenced this pull request Oct 13, 2019
When it isn't nested, a new unordered list is created for the next item

PR-URL: #29915
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 13, 2019

Landed in 19a8d22...40ef537

@Trott Trott closed this Oct 13, 2019
@nschonni nschonni deleted the fix-cve-management branch October 13, 2019 00:35
targos pushed a commit that referenced this pull request Oct 14, 2019
PR-URL: #29915
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 14, 2019
When it isn't nested, a new unordered list is created for the next item

PR-URL: #29915
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants