Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyp Python 3 fixes for Windows #29897

Closed
wants to merge 3 commits into from
Closed

Gyp Python 3 fixes for Windows #29897

wants to merge 3 commits into from

Commits on Oct 9, 2019

  1. tools: port Python 3 compat patches from node-gyp to gyp 

    Refs: nodejs/node-gyp#1820
Refs: nodejs/node-gyp#1843
    @targos
    targos committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    ad02117 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. build: always use strings for compiler version in gyp files 

    If GYP finds a string variable that can be converted to an integer,
it will do it when the variable is expanded. Use "0.0" instead of "0"
to force strings and be able to use comparison operations such as
`gas_version >= "2.26"` in Python 3.
    @targos
    targos committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    ca10dff View commit details
    Browse the repository at this point in the history

  2. tools: fix GYP MSVS solution generator for Python 3

    @targos
    targos committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    83dc1d7 View commit details
    Browse the repository at this point in the history