Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unnecessary --expose-internals flags #29886

Closed
wants to merge 1 commit into from
Closed

test: remove unnecessary --expose-internals flags #29886

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Oct 8, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Oct 8, 2019
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed async_hooks Issues and PRs related to the async hooks subsystem. labels Oct 8, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25908/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25912/

@Trott
Copy link
Member

Trott commented Oct 10, 2019

Landed in f7b5eac

@Trott Trott closed this Oct 10, 2019
Trott pushed a commit that referenced this pull request Oct 10, 2019
@addaleax @Trott
test: remove unnecessary --expose-internals flags
f7b5eac 
PR-URL: #29886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Oct 14, 2019
@addaleax @targos
test: remove unnecessary --expose-internals flags
fc53345 
PR-URL: #29886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Oct 15, 2019
Merged
@kissofire kissofire mentioned this pull request Mar 9, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 9, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Mar 10, 2021
Open
@sitedata sitedata mentioned this pull request Mar 10, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 10, 2021
Open
@137717unity 137717unity mentioned this pull request Mar 10, 2021
Open
@Rednickle Rednickle mentioned this pull request Mar 10, 2021
Open
This was referenced Mar 11, 2021
Open
Open
This was referenced Apr 26, 2021
Open
Open
@molllyn1 molllyn1 mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@baby636 baby636 mentioned this pull request Nov 5, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Nov 5, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 5, 2022
Open
@kissofire kissofire mentioned this pull request Nov 5, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 25, 2022
Open
@kissofire kissofire mentioned this pull request Dec 25, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Dec 26, 2022
Open
@137717unity 137717unity mentioned this pull request Dec 26, 2022
Open
@baby636 baby636 mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 1, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
@kissofire kissofire mentioned this pull request Oct 1, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 2, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Oct 2, 2023
Open
@137717unity 137717unity mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Jan 2, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Jan 9, 2024
Open
@kissofire kissofire mentioned this pull request Jan 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Jan 9, 2024
Open
@137717unity 137717unity mentioned this pull request Jan 9, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 9, 2024
Open
@baby636 baby636 mentioned this pull request Jan 9, 2024
Open
@baby636 baby636 mentioned this pull request Mar 19, 2024
Open
@baby636 baby636 mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @nodejs-github-bot @Trott @Fishrock123 @lpinca @targos @cjihrig @richardlau @devsnek @BridgeAR