Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] deps: patch V8 to 7.7.299.13 #29869

Closed
wants to merge 1 commit into from
Closed

[v12.x] deps: patch V8 to 7.7.299.13 #29869

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 7, 2019

@nodejs-github-bot nodejs-github-bot added v12.x v8 engine Issues and PRs related to the V8 dependency. labels Oct 7, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 7, 2019 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25890/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2542/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25897/

mhdawson
mhdawson approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2019 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25921/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2546/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25923/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25927/

@targos
Copy link
Member Author

targos commented Oct 9, 2019

Landed in 3d88b76

@targos targos closed this Oct 9, 2019
@targos targos deleted the up-v8 branch October 9, 2019 17:59
targos added a commit that referenced this pull request Oct 9, 2019
@targos
deps: patch V8 to 7.7.299.13
3d88b76 
Refs: v8/v8@7.7.299.11...7.7.299.13

PR-URL: #29869
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @cjihrig @BethGriggs @mhdawson