Remove misleading paragraph about the Legacy URL API #29844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
approved these changes
Oct 4, 2019
devnexen
approved these changes
Oct 4, 2019
|
Sharing findings (unrelated to this PR): The doc deprecation of legacy URL API was done more than a year ago in #22715 with runtime deprecation planned for Node.js 12 in PR description However, runtime deprecation is blocked on #12682 as per #22715 (review) |
trivikr
approved these changes
Oct 4, 2019
cjihrig
approved these changes
Oct 4, 2019
trivikr
added
the
author ready
antsmartian
approved these changes
Oct 5, 2019
lpinca
approved these changes
Oct 5, 2019
JungMinu
approved these changes
Oct 7, 2019
|
Landed in 064e111. |
danbev
pushed a commit
that referenced
this pull request
Oct 8, 2019
The Legacy URL API is deprecated, see: - https://nodejs.org/api/url.html#url_legacy_url_api - https://nodejs.org/api/deprecations.html# deprecations_dep0116_legacy_url_api PR-URL: #29844 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
The Legacy URL API is deprecated, see: - https://nodejs.org/api/url.html#url_legacy_url_api - https://nodejs.org/api/deprecations.html# deprecations_dep0116_legacy_url_api PR-URL: #29844 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I could tell, the Legacy URL API is in fact deprecated, see Legacy URL API and DEP0116.
Checklist
✓ documentation is changed or added
✓ commit message follows commit guidelines