Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: use uv_udp_try_send() #29832

Closed
wants to merge 2 commits into from
Closed

dgram: use uv_udp_try_send() #29832

wants to merge 2 commits into from

Commits on Oct 3, 2019

  1. dgram: use uv_udp_try_send() 

    This improves dgram performance by avoiding unnecessary async
operations.

One issue with this commit is that it seems hard to actually create
conditions under which the fallback path to the async case is
actually taken, for all supported OS, so an internal CLI option
is used for testing that path.

Another caveat is that the lack of an async operation means
that there are slight timing differences (essentially `nextTick()`
rather than `setImmediate()` for the send callback).
    @addaleax
    addaleax committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    828e08b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. fixup! dgram: use uv_udp_try_send()

    @addaleax
    addaleax committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    8c18bbb View commit details
    Browse the repository at this point in the history