Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: make tick processor detect xcodebuild errors #29830

Closed
wants to merge 1 commit into from
Closed

lib: make tick processor detect xcodebuild errors #29830

wants to merge 1 commit into from

Commits on Oct 3, 2019

  1. lib: make tick processor detect xcodebuild errors 

    `node --prof-process` on macOS calls out to nm(1) to look up C++
symbols. If Xcode hasn't been properly installed or its license
hasn't been accepted yet, it prints out an error and exits.

Before this commit, that error was swallowed and the output of
the tick processor was not showing the C++ entry points.

This commit detects that error message and turns it into an
exception. No regression test because this particular condition
is hard to test for without going to extreme lengths to mock
the output of nm.

Fixes: nodejs#29804
    @bnoordhuis
    bnoordhuis committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    4e8c37d View commit details
    Browse the repository at this point in the history