Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing deprecation code #29820

Closed
wants to merge 1 commit into from
Closed

doc: add missing deprecation code #29820

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 2, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 2, 2019

cc: @Trott

Also 👍 here to approve fast tracking.

@Trott
Copy link
Member

Trott commented Oct 2, 2019

I am really good at making this mistake.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 2, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25825/

@richardlau richardlau mentioned this pull request Oct 3, 2019
Closed
4 tasks
@richardlau

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25827/

@Trott
Copy link
Member

Trott commented Oct 3, 2019

Landed in a67b73b

@Trott Trott closed this Oct 3, 2019
Trott pushed a commit that referenced this pull request Oct 3, 2019
@cjihrig @Trott
doc: add missing deprecation code
a67b73b 
PR-URL: #29820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@cjihrig cjihrig deleted the doc branch October 4, 2019 22:40
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@cjihrig @BridgeAR
doc: add missing deprecation code
8b4f210 
PR-URL: #29820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
@richardlau richardlau mentioned this pull request Jul 14, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @Trott @nodejs-github-bot @richardlau @gengjiawen @BridgeAR