http2: support passing options of http2.connect to net.connect #29816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/http2 |
mcollina
approved these changes
Oct 5, 2019
cjihrig
reviewed
Oct 5, 2019
| @@ -2897,7 +2897,7 @@ function connect(authority, options, listener) { | |||
| } else { | |||
| switch (protocol) { | |||
| case 'http:': | |||
| socket = net.connect(options.port || port, options.host || host); | |||
| socket = net.connect({ port, host, ...options }); | |||
There was a problem hiding this comment.
Is it intentional that options.host and options.port would now take precedence over those same fields in authority?
There was a problem hiding this comment.
Is it intentional that options.host and options.port would now take precedence over those same fields in authority
I think yes, however this behavior wasn't changed here but in #28584.
jasnell
approved these changes
Oct 5, 2019
cjihrig
approved these changes
Oct 5, 2019
trivikr
approved these changes
Oct 5, 2019
ZYSzys
added
the
author ready
gengjiawen
approved these changes
Oct 7, 2019
ZYSzys
added a commit
that referenced
this pull request
Oct 7, 2019
PR-URL: #29816 Fixes: #29811 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
|
Landed in 95266db. |
3 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #29816 Fixes: #29811 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
This was referenced Mar 11, 2021
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29811
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes