crypto: remove arbitrary UTF16 restriction #29795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 71f633a, this is no longer necessary. Refs: nodejs#22622 Fixes: nodejs#29793
addaleax
added
crypto
nodejs-github-bot
added
c++
targos
approved these changes
Oct 1, 2019
addaleax
added
the
author ready
BridgeAR
approved these changes
Oct 1, 2019
lpinca
approved these changes
Oct 1, 2019
cjihrig
approved these changes
Oct 1, 2019
Co-Authored-By: Colin Ihrig <[email protected]>
jasnell
approved these changes
Oct 1, 2019
devnexen
approved these changes
Oct 1, 2019
|
Landed in 389969e |
Trott
pushed a commit
that referenced
this pull request
Oct 3, 2019
Since 71f633a, this is no longer necessary. Refs: #22622 Fixes: #29793 PR-URL: #29795 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
Since 71f633a, this is no longer necessary. Refs: #22622 Fixes: #29793 PR-URL: #29795 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 71f633a, this is no longer necessary.
Refs: #22622
Fixes: #29793
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes