Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reuse link indexes for n-api.md #29787

Closed
wants to merge 1 commit into from
Closed

doc: reuse link indexes for n-api.md #29787

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

Index links at the bottom of the page.

Refs: #29768 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Oct 1, 2019
BridgeAR
BridgeAR approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott reviewed Oct 1, 2019
View reviewed changes
doc/api/n-api.md Show resolved Hide resolved
mhdawson
mhdawson approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

This comment has been minimized.

Sign in to view
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2019
@Trott

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member

Trott commented Oct 3, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3969/

Trott pushed a commit that referenced this pull request Oct 3, 2019
@legendecas @Trott
doc: reuse link indexes for n-api.md
d742535 
PR-URL: #29787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 3, 2019

Landed in d742535

@Trott Trott closed this Oct 3, 2019
@legendecas legendecas deleted the n-api-doc-links branch October 4, 2019 00:44
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@legendecas @BridgeAR
doc: reuse link indexes for n-api.md
a00cd17 
PR-URL: #29787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@legendecas @Trott @jasnell @gabrielschulhof @BridgeAR @mhdawson @nodejs-github-bot