vm: SourceTextModule refactor #29776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
devsnek
force-pushed
the
vm-module-2
branch
from
bd941bd
to
2dd3bfb
Compare
|
cc @nodejs/vm |
devsnek
removed
the
lib / src
targos
reviewed
Sep 30, 2019
jasnell
approved these changes
Sep 30, 2019
targos
approved these changes
Sep 30, 2019
devsnek
force-pushed
the
vm-module-2
branch
from
6fc2a13
to
907f427
Compare
guybedford
reviewed
Sep 30, 2019
JungMinu
approved these changes
Oct 1, 2019
BridgeAR
reviewed
Oct 1, 2019
| this.#error; | ||
| } catch { | ||
| throw new ERR_VM_MODULE_NOT_MODULE(); | ||
| } |
There was a problem hiding this comment.
I suggest to abstract this into a private function for less repetition. That way it could be used as: this.#getPrivateProperty(name) where name would e.g., be '#error'.
There was a problem hiding this comment.
obj['#error'] is not the same as obj.#error, also you have to check for this.#getPrivateProperty in the first place 🙃
There was a problem hiding this comment.
Uh, of course! Too bad that it seems like there's no nice way around this 😞
There was a problem hiding this comment.
It's pretty ugly but it should be possible to abstract it like this:
function getPrivateProperty(module, name) {
try {
switch (name) {
case 'error':
return module.#error;
...
}
} catch {
throw new ERR_VM_MODULE_NOT_MODULE();
}
}There was a problem hiding this comment.
I think how the current code is the best we can get it. you can blame tc39 for not generalizing private fields better 🤷
- Removes redundant `instantiate` method - Refactors `link` to match the spec linking steps more accurately - Removes URL validation from SourceTextModule specifiers - DRYs some dynamic import logic Closes nodejs#29030 Co-Authored-By: Michaël Zasso <[email protected]>
devsnek
added
the
author ready
Trott
pushed a commit
that referenced
this pull request
Oct 2, 2019
- Removes redundant `instantiate` method - Refactors `link` to match the spec linking steps more accurately - Removes URL validation from SourceTextModule specifiers - DRYs some dynamic import logic Closes: #29030 Co-Authored-By: Michaël Zasso <[email protected]> PR-URL: #29776 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Landed in 5e7946f |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
- Removes redundant `instantiate` method - Refactors `link` to match the spec linking steps more accurately - Removes URL validation from SourceTextModule specifiers - DRYs some dynamic import logic Closes: #29030 Co-Authored-By: Michaël Zasso <[email protected]> PR-URL: #29776 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instantiatemethodlinkto match the spec linking steps more accuratelyCloses #29030
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes