Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix process.ppid 'added in' info #29772

Closed
wants to merge 1 commit into from
Closed

doc: fix process.ppid 'added in' info #29772

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Sep 30, 2019

The PR #16839 originally landed in v9.2.0 but was later backported to v8.10.0 and 6.13.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 30, 2019
@watson watson added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 1, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25786/

@watson
Copy link
Member Author

watson commented Oct 1, 2019

Probably overkill to run all the tests (been a while since I've used the CI system 😅), but I assume the test failures are unrelated? 🤔

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2019 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25787/ ✔️

@Trott
Copy link
Member

Trott commented Oct 1, 2019

Probably overkill to run all the tests (been a while since I've used the CI system 😅), but I assume the test failures are unrelated? 🤔

For documentation-only changes, you can run node-test-pull-request-lite-pipeline which runs only a linting job and a single (very fast) host for tests.

@Trott
Copy link
Member

Trott commented Oct 1, 2019

The fast-track label was added by @watson. If you're a Collaborator, please 👍 here to approve fast-tracking.

@BridgeAR
Copy link
Member

BridgeAR commented Oct 1, 2019

@nodejs/tooling @nodejs/releasers it would be great if we could somehow add this information when preparing a new release. We'd need a tool that parses the difference between two *.md file versions and that is capable to automatically change the added information to our standard.

That way such PRs would become obsolete in the future. Right now this information is almost always missing.

@Trott
Copy link
Member

Trott commented Oct 1, 2019

Landed in a006465

@Trott Trott closed this Oct 1, 2019
Trott pushed a commit that referenced this pull request Oct 1, 2019
@watson @Trott
doc: improve process.ppid 'added in' info
a006465 
PR-URL: #29772
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@watson watson deleted the ppid-docs branch October 2, 2019 08:58
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@watson @BridgeAR
doc: improve process.ppid 'added in' info
bc48646 
PR-URL: #29772
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watson @nodejs-github-bot @Trott @BridgeAR @jasnell @lpinca @cjihrig