Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify --pending-deprecation effects on Buffer() usage #29769

Closed
wants to merge 1 commit into from
Closed

doc: clarify --pending-deprecation effects on Buffer() usage #29769

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 30, 2019 •
edited
Loading

Alternative to #29725

Refs: #29725 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Sep 30, 2019
@Trott Trott mentioned this pull request Sep 30, 2019
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented Sep 30, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3946/

@lholmquist
Copy link
Contributor

+1 I'll close the PR i opened #29725 in favor of this one. I didn't realize there was more to the flag for this particular example

mhdawson
mhdawson approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2019
@Trott
Copy link
Member Author

Trott commented Oct 2, 2019

Landed in 344c5c4

@Trott Trott closed this Oct 2, 2019
Trott added a commit that referenced this pull request Oct 2, 2019
@Trott
doc: clarify --pending-deprecation effects on Buffer() usage
344c5c4 
Refs: #29725 (comment)

PR-URL: #29769
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@Trott @BridgeAR
doc: clarify --pending-deprecation effects on Buffer() usage
906245e 
Refs: #29725 (comment)

PR-URL: #29769
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
@kissofire kissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedata sitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity 137717unity mentioned this pull request Feb 26, 2021
Open
@Rednickle Rednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofire kissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofire kissofire mentioned this pull request Dec 6, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lholmquist lholmquist lholmquist approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @lholmquist @jasnell @addaleax @lpinca @cjihrig @BridgeAR @mhdawson @nodejs-github-bot