Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 6.5.0 #29759

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 6.5.0 #29759

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 29, 2019

Update ESLint to 6.5.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 6.5.0
e1dac91 
Update ESLint to 6.5.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 29, 2019
Trott
Trott approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp LGTM

trivikr
trivikr approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott mentioned this pull request Oct 1, 2019
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Oct 1, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3950/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 1, 2019

@Trott please hold off on landing this one. The ESLint team just put out a patch release. I'm going to update this PR to 6.5.1.

1 similar comment
@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 1, 2019

@Trott please hold off on landing this one. The ESLint team just put out a patch release. I'm going to update this PR to 6.5.1.

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 1, 2019

Nevermind. I missed #29785.

@cjihrig cjihrig closed this Oct 1, 2019
@cjihrig cjihrig deleted the eslint branch October 1, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @Trott @trivikr @nodejs-github-bot