Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: writable.write arg type #29746

Closed
wants to merge 1 commit into from
Closed

test: writable.write arg type #29746

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Sep 28, 2019 •
edited
Loading

Adds some test for passing invalid args to Writable.write

This basically ports some test from Readable.push.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag force-pushed the test-writable-write-invalid-chunk branch from 65df100 to af366a5 Compare September 28, 2019 07:49
@ronag
Copy link
Member Author

ronag commented Sep 28, 2019

There is a slight discrepancy between null and undefined both inside and outside objectMode which I'd hope someone could clarify the rationale behind.

@ronag ronag force-pushed the test-writable-write-invalid-chunk branch from af366a5 to 780f62d Compare September 28, 2019 07:53
@Trott
Copy link
Member

Trott commented Oct 1, 2019

@nodejs/testing

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2019 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25780/ ✔️

@Trott
Copy link
Member

Trott commented Oct 2, 2019

@nodejs/streams (particularly on the "is undefined being handled correctly?" question)

mcollina
mcollina approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/parallel/test-stream-writable-invalid-chunk.js Show resolved Hide resolved
test/parallel/test-stream-writable-invalid-chunk.js Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2019
@Trott
Copy link
Member

Trott commented Oct 3, 2019

Landed in 6ea51bc

@Trott Trott closed this Oct 3, 2019
Trott pushed a commit that referenced this pull request Oct 3, 2019
@ronag @Trott
test: add test for writable.write() argument types
6ea51bc 
PR-URL: #29746
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@ronag @BridgeAR
test: add test for writable.write() argument types
bf1727a 
PR-URL: #29746
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @Trott @nodejs-github-bot @mcollina