[v10.x] deps: do not link against librt #29729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not needed, and causes an unnecessary runtime dependency with some linkers, such as devtoolset-6 on centos7-ppc64le. See: nodejs#29718
nodejs-github-bot
added
libuv
sam-github
changed the title
BridgeAR
approved these changes
Sep 26, 2019
BethGriggs
approved these changes
Sep 27, 2019
devnexen
approved these changes
Sep 27, 2019
|
Only v10.x is affected? |
|
8 isn't affected, because we aren't going to change anything about its build, its almost EOL. EDIT: specifically, we aren't going to change from building on ubuntu-1404, even though its EOL, and start building on centos7 -- so we don't care about this link problem, because it seems devtools-6 on centos7 specific. #29727 is the master equivalent, maybe this is a backport, but the files are completely different, the v8.gyp changed location from deps to tools. |
BethGriggs
pushed a commit
that referenced
this pull request
Oct 1, 2019
It is not needed, and causes an unnecessary runtime dependency with some linkers, such as devtoolset-6 on centos7-ppc64le. See: #29718 PR-URL: #29729 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: David Carlier <[email protected]>
|
Landed in 7f48519 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed, and causes an unnecessary runtime dependency with some
linkers, such as devtoolset-6 on centos7-ppc64le.
Se
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes