Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document that iv may be null when using createCipheriv() #29684

Closed
wants to merge 1 commit into from
Closed

doc: document that iv may be null when using createCipheriv() #29684

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This adds null to the supported types of the iv option when
using crypto.createCipheriv().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 23, 2019
@BridgeAR
doc: document that iv may be null when using createCipheriv()
a6d651a 
This adds `null` to the supported types of the `iv` option when
using `crypto.createCipheriv()`.
@BridgeAR BridgeAR changed the title doc: document that iv may be null hwne using createCipheriv() doc: document that iv may be null when using createCipheriv() Sep 23, 2019
@BridgeAR
Copy link
Member Author

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3927/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2019
Trott pushed a commit that referenced this pull request Sep 25, 2019
@BridgeAR @Trott
doc: document that iv may be null when using createCipheriv()
5058c7f 
This adds `null` to the supported types of the `iv` option when
using `crypto.createCipheriv()`.

PR-URL: #29684
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 25, 2019

Landed in 5058c7f

@Trott Trott closed this Sep 25, 2019
targos pushed a commit that referenced this pull request Oct 1, 2019
@BridgeAR @targos
doc: document that iv may be null when using createCipheriv()
3de1fc6 
This adds `null` to the supported types of the `iv` option when
using `crypto.createCipheriv()`.

PR-URL: #29684
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
@BridgeAR BridgeAR deleted the fix-crypto-iv-doc branch January 20, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @Trott @bnoordhuis @jasnell @lpinca @devnexen @nodejs-github-bot