Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: deprecate process._tickCallback #29671

Closed
wants to merge 5 commits into from
Closed

process: deprecate process._tickCallback #29671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a198e06
process: deprecate process._tickCallback
lholmquist Sep 20, 2019
042734c
squash: update deprecation code to be generic
lholmquist Sep 25, 2019
755df8d
squash: update pr-url in deprecation yaml
lholmquist Sep 25, 2019
a1a9df9
squash: small update after the rebase
lholmquist Oct 4, 2019
2781b4b
squash: put back dep code and change the metadata order
lholmquist Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2523,14 +2523,18 @@ Prefer [`response.socket`][] over [`response.connection`][] and
### DEP0134: process._tickCallback
lholmquist marked this conversation as resolved.
Show resolved Hide resolved
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/29671
description: Runtime deprecation.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/29781
description: Documentation-only deprecation.
-->
Type: Documentation-only (supports [`--pending-deprecation`][])
Type: Runtime

The `process._tickCallback` property was never documented as
an officially supported API.
an officially supported API. Please use `process.runNextTicks`
instead.

[`--pending-deprecation`]: cli.html#cli_pending_deprecation
[`--throw-deprecation`]: cli.html#cli_throw_deprecation
Expand Down
11 changes: 7 additions & 4 deletions lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,13 @@ process.emitWarning = emitWarning;
const { nextTick, runNextTicks } = setupTaskQueue();
process.nextTick = nextTick;
// Used to emulate a tick manually in the JS land.
// A better name for this function would be `runNextTicks` but
// it has been exposed to the process object so we keep this legacy name
// TODO(joyeecheung): either remove it or make it public
process._tickCallback = runNextTicks;
process.runNextTicks = runNextTicks;
process._tickCallback = deprecate(
runNextTicks,
'process._tickCallback is deprecated. ' +
'Please use `process.runNextTicks` instead.',
'DEP0134');
lholmquist marked this conversation as resolved.
Show resolved Hide resolved


const { getTimerCallbacks } = require('internal/timers');
const { setupTimers } = internalBinding('timers');
Expand Down
4 changes: 0 additions & 4 deletions lib/internal/bootstrap/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,6 @@ function initializeDeprecations() {
process.binding = deprecate(process.binding,
'process.binding() is deprecated. ' +
'Please use public APIs instead.', 'DEP0111');

process._tickCallback = deprecate(process._tickCallback,
'process._tickCallback() is deprecated',
'DEP0134');
}

// Create global.process and global.Buffer as getters so that we have a
Expand Down