doc: fix type of atime/mtime

[exoego]

It seems that fs.unlinkSync and fs.utimesSync can accept number, Date or string as same as fs.unlink and fs.utimes.

node/lib/fs.js

Lines 1177 to 1196 in 3a2e75d

	function utimes(path, atime, mtime, callback) {
	callback = makeCallback(callback);
	path = getValidatedPath(path);
	const req = new FSReqCallback();
	req.oncomplete = callback;
	binding.utimes(pathModule.toNamespacedPath(path),
	toUnixTimestamp(atime),
	toUnixTimestamp(mtime),
	req);
	}
	function utimesSync(path, atime, mtime) {
	path = getValidatedPath(path);
	const ctx = { path };
	binding.utimes(pathModule.toNamespacedPath(path),
	toUnixTimestamp(atime), toUnixTimestamp(mtime),
	undefined, ctx);
	handleErrorFromBinding(ctx);
	}

node/lib/fs.js

Lines 1189 to 1206 in 3a2e75d

	function utimesSync(path, atime, mtime) {
	path = getValidatedPath(path);
	const ctx = { path };
	binding.utimes(pathModule.toNamespacedPath(path),
	toUnixTimestamp(atime), toUnixTimestamp(mtime),
	undefined, ctx);
	handleErrorFromBinding(ctx);
	}
	function futimes(fd, atime, mtime, callback) {
	validateInt32(fd, 'fd', 0);
	atime = toUnixTimestamp(atime, 'atime');
	mtime = toUnixTimestamp(mtime, 'mtime');
	const req = new FSReqCallback();
	req.oncomplete = makeCallback(callback);
	binding.futimes(fd, atime, mtime, req);
	}

Checklist

• documentation is changed or added
• commit message follows commit guidelines

[BridgeAR]

I think it would be best to keep integer instead of number. We might want to have a stricter validation here at some point. I am not sure what the behavior would be in case a decimal is used instead of an integer.

[exoego]

It seems that there is no validation nor rounding, so decimal will be used as decimal.

node/lib/internal/fs/utils.js

Lines 452 to 457 in 0692995

	if (Number.isFinite(time)) {
	if (time < 0) {
	return Date.now() / 1000;
	}
	return time;
	}

Are these supposed to be integer?
Updated so in 019b628

[lpinca]

In that case I think number is more appropriate. Sorry for the trouble.

[exoego]

Fixed in 22157ef

[Trott]

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3953/

[Trott]

Landed in 16e47b9