tls: honor pauseOnConnect in tls.Server constructor #29632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the parent constructor in `tls.Server` is not sufficient to pass along the `pauseOnConnect` option - it must also be passed when calling the parent constructor in `TLSSocket`. Tests were updated to cover the use of all possible net.Server options in the tls.Server constructor. Fixes: #29620 Refs: #27665
r1b
commented
Sep 20, 2019
| @@ -411,6 +411,7 @@ function TLSSocket(socket, opts) { | |||
| net.Socket.call(this, { | |||
| handle: this._wrapHandle(wrap), | |||
| allowHalfOpen: socket ? socket.allowHalfOpen : tlsOptions.allowHalfOpen, | |||
There was a problem hiding this comment.
As written, tlsOptions.allowHalfOpen will never be set - right? Should I also add that to the TLSSocket call in tlsConnectionListener?
|
Sorry, this needs more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29620
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes