-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: try showing stack traces when process._fatalException is not set #29624
Conversation
So that the stack trace of errors shown in internal code run during bootstrap (before process._fatalException is set) can be printed.
Before the patch if you make a typo in, e.g.
After the patch it looks like this:
|
@nodejs/collaborators This one could use some reviews. |
Is it reasonable/feasible to add a test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
I can't think of an easy or particularly necessary way to test this (since it should only occur on internal dev mistakes).
Landed in 355f2ad |
So that the stack trace of errors shown in internal code run during bootstrap (before process._fatalException is set) can be printed. PR-URL: nodejs#29624 Refs: nodejs#29593 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
So that the stack trace of errors shown in internal code run during bootstrap (before process._fatalException is set) can be printed. PR-URL: #29624 Refs: #29593 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
So that the stack trace of errors shown in internal code run during
bootstrap (before process._fatalException is set) can be printed.
Refs: #29593
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes