src: disconnect inspector before exiting out of fatal exception #29611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that coverage, .etc are properly written in case of a normal fatal exception.
joyeecheung
force-pushed
the
fix-coverage-throw
branch
from
1da18a1 to
83fc7ad
Compare
nodejs-github-bot
added
the
c++
joyeecheung
added
errors
joyeecheung
commented
Sep 19, 2019
src/node_errors.cc
Outdated
| @@ -978,6 +978,7 @@ void TriggerUncaughtException(Isolate* isolate, | |||
|
|
|||
| // Now we are certain that the exception is fatal. | |||
| ReportFatalException(env, error, message, EnhanceFatalException::kEnhance); | |||
| WaitForInspectorDisconnect(env); | |||
There was a problem hiding this comment.
I didn't leave this for other Exit() calls in TriggerUncaughtException() as those cases are more abnormal than this (e.g. the global uncaught exception handler throws itself, or the global hook is monkey-pached incorrectly) and I think it would unsafe to wait until the inspector shut down in those cases.
joyeecheung
commented
Sep 19, 2019
| @@ -978,6 +978,9 @@ void TriggerUncaughtException(Isolate* isolate, | |||
|
|
|||
| // Now we are certain that the exception is fatal. | |||
| ReportFatalException(env, error, message, EnhanceFatalException::kEnhance); | |||
| #if HAVE_INSPECTOR | |||
| profiler::EndStartedProfilers(env); | |||
There was a problem hiding this comment.
Uh just realized we should call profiler::EndStartedProfilers instead since the whole WaitForInspectorDisconnect resets signals.
| @@ -0,0 +1,7 @@ | |||
| const a = 99; | |||
| if (true) { | |||
There was a problem hiding this comment.
This is in the test though?
cjihrig
approved these changes
Sep 19, 2019
devnexen
approved these changes
Sep 19, 2019
bcoe
suggested changes
Sep 19, 2019
test/parallel/test-v8-coverage.js
Outdated
| @@ -35,6 +35,24 @@ function nextdir() { | |||
| assert.strictEqual(fixtureCoverage.functions[0].ranges[1].count, 0); | |||
| } | |||
|
|
|||
| // Outputs coverage when process.exit(1) exits process. | |||
There was a problem hiding this comment.
perhaps, change to:
// Outputs coverage when error is thrown in first tick.
There was a problem hiding this comment.
Uh thanks for catching my copy-past error :)
joyeecheung
force-pushed
the
fix-coverage-throw
branch
from
a85298b to
07c3ae3
Compare
bcoe
approved these changes
Sep 22, 2019
danbev
added
the
author ready
|
@joyeecheung This is ready to land in your opinion? |
|
@Trott yes |
bcoe
pushed a commit
to bcoe/node-1
that referenced
this pull request
Sep 24, 2019
So that coverage, .etc are properly written in case of a normal fatal exception. PR-URL: nodejs#29611 Fixes: nodejs#29570 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Coe <[email protected]>
|
Landed in b263423 |
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
So that coverage, .etc are properly written in case of a normal fatal exception. PR-URL: #29611 Fixes: #29570 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that coverage, .etc are properly written in case of a normal
fatal exception.
Fixes: #29570
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes