Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct trivial misspelling in AUTHORS #29597

Closed
wants to merge 2 commits into from
Closed

correct trivial misspelling in AUTHORS #29597

wants to merge 2 commits into from

Conversation

gcr
Copy link
Contributor

@gcr gcr commented Sep 18, 2019 •
edited
Loading

my legal name changed, so i'm removing lingering references to my old name from the Internet.

hopefully this should be a simple change?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@gcr
correct trivial misspelling in AUTHORS
cc27326 
my legal name changed, so i'm removing lingering references to my old name from the Internet.

hopefully this should be a simple change?
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 18, 2019
@addaleax
Copy link
Member

I think you’ll also want to replace the entry in .mailmap (and move it, as the file’s alphabetically ordered), as AUTHORS is semi-automatically generated based on the git log + the information in .mailmap.

@addaleax
Copy link
Member

(Did that for you, assuming that that’s okay.)

Lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3915/pipeline

Collaborators, feel free to 👍 this comment to approve fast-tracking.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 18, 2019
addaleax pushed a commit that referenced this pull request Sep 18, 2019
@gcr @addaleax
doc: correct trivial misspelling in AUTHORS
9fb8b8d 
my legal name changed, so i'm removing lingering references
to my old name from the Internet.

PR-URL: #29597
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax
Copy link
Member

Landed in 9fb8b8d

@addaleax addaleax closed this Sep 18, 2019
@gcr
Copy link
Contributor Author

gcr commented Sep 18, 2019

brilliant, thank you~!!

targos pushed a commit that referenced this pull request Sep 20, 2019
@gcr @targos
doc: correct trivial misspelling in AUTHORS
eb3600b 
my legal name changed, so i'm removing lingering references
to my old name from the Internet.

PR-URL: #29597
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@gcr @BridgeAR
doc: correct trivial misspelling in AUTHORS
4954792 
my legal name changed, so i'm removing lingering references
to my old name from the Internet.

PR-URL: #29597
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gcr @addaleax @lpinca @nodejs-github-bot