Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 7.7.299.10 #29472

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.7.299.10 #29472

wants to merge 1 commit into from

Conversation

Hakerh400
Copy link
Contributor

Fixes #29462

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 6, 2019
@targos
Copy link
Member

targos commented Sep 6, 2019

This fix was backmerged in 7.7-lkgr: https://github.com/v8/v8/commits/7.7-lkgr.
Could you update V8 to the latest version instead?
The command is git node v8 minor.

@Hakerh400 Hakerh400 changed the title deps: V8: cherry-pick 1990b1e deps: patch V8 to 7.7.299.10 Sep 6, 2019
targos
targos approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 6, 2019 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25376/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2495/

@bricss bricss mentioned this pull request Sep 15, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25508/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25569/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25593/

@targos
Copy link
Member

targos commented Sep 20, 2019

Landed in dc7c7b8

@targos targos closed this Sep 20, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
@Hakerh400 @targos
deps: patch V8 to 7.7.299.10
dc7c7b8 
Refs: v8/v8@7.7.299.8...7.7.299.10

PR-URL: #29472
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@Hakerh400 Hakerh400 deleted the reg branch September 20, 2019 08:28
targos pushed a commit that referenced this pull request Sep 23, 2019
@Hakerh400 @targos
deps: patch V8 to 7.7.299.10
46d4f93 
Refs: v8/v8@7.7.299.8...7.7.299.10

PR-URL: #29472
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@Hakerh400 @BridgeAR
deps: patch V8 to 7.7.299.10
e4a51ad 
Refs: v8/v8@7.7.299.8...7.7.299.10

PR-URL: #29472
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR mentioned this pull request Sep 26, 2019
Closed
2 tasks
@targos targos mentioned this pull request Oct 22, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29474/

@kissofire kissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedata sitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity 137717unity mentioned this pull request Feb 26, 2021
Open
@Rednickle Rednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofire kissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofire kissofire mentioned this pull request Dec 6, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regexp lookBehind bug?
5 participants
@Hakerh400 @targos @nodejs-github-bot @cjihrig @gengjiawen