-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10.x] n-api: mark version 5 N-APIs as stable #29458
[v10.x] n-api: mark version 5 N-APIs as stable #29458
Conversation
PR-URL: nodejs#29401 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
I suggest updating |
@richardlau I created #29461 which I can then backport. Is that how you envisioned it? |
@gabrielschulhof, @richardlau not sure if a PR with REPLACEME's for all of the version make sense as I don't think you'll be able to land until those are replaced or they might get replaced with the wrong version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I envision that each backport would have a single |
@BethGriggs I assume this will be part of the next 10.x SemVer minor? |
PR-URL: #29401 Backport-PR-URL: #29458 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Landed on |
PR-URL: #29401
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes