-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf_hooks: improve http2 import #29419
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import http2 internal bindings on each collectHttp2Stats call is not required.
nodejs-github-bot
added
the
perf_hooks
Issues and PRs related to the implementation of the Performance Timing API.
label
Sep 3, 2019
cjihrig
approved these changes
Sep 3, 2019
devnexen
approved these changes
Sep 3, 2019
trivikr
approved these changes
Sep 3, 2019
lpinca
approved these changes
Sep 3, 2019
trivikr
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 3, 2019
jasnell
approved these changes
Sep 3, 2019
JungMinu
approved these changes
Sep 6, 2019
Landed in 6186302 |
Trott
pushed a commit
that referenced
this pull request
Sep 6, 2019
Import http2 internal bindings on each collectHttp2Stats call is not required. PR-URL: #29419 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Import http2 internal bindings on each collectHttp2Stats call is not required. PR-URL: #29419 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
perf_hooks
Issues and PRs related to the implementation of the Performance Timing API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX) passesNearly ~119ns for each
collectHttp2Stats
call.const http2 = internalBinding('http2');
=>20001: 36.200362ms
if (http2 === undefined) http2 = internalBinding('http2');
=>20001: 33.814263ms
(36.200362 - 33.814263) * 1e6 / 20001 = 119
Same lazy
require
innet
module: https://github.com/nodejs/node/blob/v12.9.1/lib/net.js#L940Benchmarked with:
Code in
perf_hooks.js
was changed to: