Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove flaky status for test-statwatcher #29392

Merged
merged 0 commits into from
Sep 3, 2019
Merged

test: remove flaky status for test-statwatcher #29392

merged 0 commits into from
Sep 3, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 1, 2019

test-statwatcher does not appear to be failing anymore in CI. Remove
"flaky" status for the test.

Closes: #21425

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Sep 1, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25310/

@Trott
Copy link
Member Author

Trott commented Sep 3, 2019

Landed in f2c573c

@Trott Trott closed this Sep 3, 2019
@Trott Trott deleted the statwatcher branch September 3, 2019 14:11
@Trott Trott merged commit f2c573c into nodejs:master Sep 3, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
@Trott @targos
test: remove flaky status for test-statwatcher
75c559d 
test-statwatcher does not appear to be failing anymore in CI. Remove
"flaky" status for the test.

Closes: #21425

PR-URL: #29392
Fixes: #21425
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@patilharshal16 patilharshal16 patilharshal16 approved these changes

@devnexen devnexen devnexen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky async-hooks/test-statwatcher
10 participants
@Trott @nodejs-github-bot @bnoordhuis @lpinca @targos @cjihrig @gengjiawen @devnexen @patilharshal16 @trivikr