doc: consistent indenting for unordered list items #29390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address Markdownlint MD006 rule. Can flag when list items aren't indented far enough.
Address Markdownlint MD007 rule. Default suggestion is 2 space indenting for unordered list items.
nodejs-github-bot
added
build
nschonni
commented
Sep 1, 2019
| @@ -221,10 +221,10 @@ This is a security release. All Node.js users should consult the security releas | |||
|
|
|||
| ### Notable changes | |||
|
|
|||
| **http**: | |||
| * **http**: | |||
There was a problem hiding this comment.
Made list item to be consistent with other change logs
| - Jeremy Whitlock (@whitlockjc) | ||
| - Matt Loring (@matthewloring) | ||
| - Phillip Johnsen (@phillipj) | ||
| - Andreas Madsen (@AndreasMadsen) |
There was a problem hiding this comment.
This wasn't indented far enough
| - Implement new `TypedArray.from()` and `TypedArray.of()` functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. | ||
| - Implement arrow functions, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions for further information. | ||
| - Full ChangeLog available at https://github.com/v8/v8-git-mirror/blob/4.5.103/ChangeLog | ||
| - Implement new `TypedArray` prototype methods: `copyWithin()`, `every()`, `fill()`, `filter()`, `find()`, `findIndex()`, `forEach()`, `indexOf()`, `join()`, `lastIndexOf()`, `map()`, `reduce()`, `reduceRight()`, `reverse()`, `slice()`, `some()`, `sort()`. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. |
There was a problem hiding this comment.
This wasn't indented far enough
devnexen
reviewed
Sep 1, 2019
devnexen
approved these changes
Sep 1, 2019
Trott
approved these changes
Sep 3, 2019
Trott
added
the
author ready
jasnell
approved these changes
Sep 3, 2019
Trott
pushed a commit
that referenced
this pull request
Sep 4, 2019
Address Markdownlint MD006 rule. Can flag when list items aren't indented far enough. PR-URL: #29390 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott
pushed a commit
that referenced
this pull request
Sep 4, 2019
Address Markdownlint MD007 rule. Default suggestion is 2 space indenting for unordered list items. PR-URL: #29390 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 3c84556...a3307ea |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Address Markdownlint MD006 rule. Can flag when list items aren't indented far enough. PR-URL: #29390 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Address Markdownlint MD007 rule. Default suggestion is 2 space indenting for unordered list items. PR-URL: #29390 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes