Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update experimental loader hooks example code #29373

Closed
wants to merge 1 commit into from
Closed

doc: update experimental loader hooks example code #29373

wants to merge 1 commit into from

Commits on Sep 9, 2019

  1. doc: update experimental loader hooks example code 

    It fix 2 issues in provided Loader hooks examples:
1. Original ``new URL(`${process.cwd()}/`, 'file://');``
is not cross-platform, it gives wrong URL on windows
2. Based on `CHECK` in ModuleWrap::Resolve (node 12.9.1,
https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132)
the 2nd parameter should be a `string`, not an `URL` object
    @zaverden
    zaverden committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    abb6237 View commit details
    Browse the repository at this point in the history