child_process: remove use of stream private state #29358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
addaleax
approved these changes
Aug 28, 2019
ckarande
changed the title
mscdex
reviewed
Aug 28, 2019
lib/internal/child_process.js
Outdated
| @@ -298,8 +298,7 @@ function flushStdio(subprocess) { | |||
| // which data can be read from a stream, e.g. being consumed on the | |||
| // native layer directly as a StreamBase. | |||
| if (!stream || !stream.readable || | |||
| stream._readableState.readableListening || | |||
| stream[kIsUsedAsStdio]) { | |||
| stream[kIsUsedAsStdio]) { | |||
There was a problem hiding this comment.
Suggested change
| stream[kIsUsedAsStdio]) { | |
| stream[kIsUsedAsStdio]) { |
There was a problem hiding this comment.
Alternatively, it should be able to fit on one line now:
if (!stream || !stream.readable || stream[kIsUsedAsStdio]) {There was a problem hiding this comment.
Thanks @mscdex for the suggestion. Updated the PR accordingly.
|
@addaleax I'd prefer to land this on Node 12 to catch a regression early |
jasnell
approved these changes
Aug 28, 2019
patilharshal16
approved these changes
Sep 2, 2019
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 12, 2020
BridgeAR
approved these changes
Jan 12, 2020
Trott
pushed a commit
that referenced
this pull request
Jan 12, 2020
PR-URL: #29358 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in f9c16b8 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #29358 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In child_process.js L#301, the state
stream._readableState.readableListeningis used to determine if any paused stdio streams exist, and if so, theresume()method is used to flush it. Checking this state seems unnecessary as theresume()method has no effect on the streams subscribed withreadableevent. Also, all existing tests pass even after removing it.If this is correct analysis, this PR includes change as part of the issue #445, to remove direct references to internal state of the stream implementation.
cc: @addaleax @mcollina
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes