Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not crash when accessing empty WeakRefs #29289

Closed
wants to merge 1 commit into from
Closed

src: do not crash when accessing empty WeakRefs #29289

wants to merge 1 commit into from

Commits on Aug 24, 2019

  1. src: do not crash when accessing empty WeakRefs 

    Making `.incRef()` and `.decRef()` fail silently leads to better error
messages when trying to access the underlying value (as opposed to
crashing inside these methods).

Refs: nodejs#25461 (comment)
    @addaleax
    addaleax committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    2804205 View commit details
    Browse the repository at this point in the history