Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix mixup with bytes.decode() and str.encode() #29208

Closed
wants to merge 1 commit into from
Closed

tools: fix mixup with bytes.decode() and str.encode() #29208

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 19, 2019

We want to read a bytes file and decode the contents as utf-8 so we can compare against a utf-8 pattern.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss requested a review from refack August 19, 2019 17:25
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 19, 2019
@targos
Copy link
Member

targos commented Aug 19, 2019

Subsystem should be "tools"

@cclauss cclauss mentioned this pull request Aug 19, 2019
Closed
63 tasks
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Aug 19, 2019
@addaleax addaleax changed the title v8: fix mixup with bytes.decode() and str.encode() tools: fix mixup with bytes.decode() and str.encode() Aug 20, 2019
targos
targos approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That's exactly what we have in canary-base

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25123/

@cclauss
tools: fix mixup with bytes.decode() and str.encode()
ecda222 
We want to read a bytes file and decode the contents as utf-8 so we can compare against a utf-8 pattern.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25141/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25160/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25174/

@Trott
Copy link
Member

Trott commented Aug 22, 2019

Landed in 6afd1a3

@Trott Trott closed this Aug 22, 2019
Trott pushed a commit that referenced this pull request Aug 22, 2019
@cclauss @Trott
tools: fix mixup with bytes.decode() and str.encode()
6afd1a3 
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: #29208
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@cclauss cclauss deleted the GN-scraper.decode branch August 22, 2019 05:55
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@cclauss @BridgeAR
tools: fix mixup with bytes.decode() and str.encode()
925141f 
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: #29208
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@refack refack Awaiting requested review from refack

Assignees
No one assigned
Labels
python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cclauss @targos @nodejs-github-bot @Trott @addaleax @richardlau