[x] stream: properties cleanup

[ronag]

• Streams are always initialized. Remove redundant checks.
• enumerable is false by default so there is no reason to explicitly set it.
• prefer method() {} over method: function() {}
• move properties directly after constructor

Refs: #28967, #28991

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[lpinca]

I like this but what was the reason for the state check? Did you investigate / run a git blame?

[ronag]

@lpinca: I couldn't find the reason. I asked @mcollina if he knew any reason and he was (as far as I understood) of the opinion that they are not needed.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24896/

[lpinca]

I think it was done as a safeguard for cases where a subclass instance uses the getters/setters before calling the super constructor.

[ronag]

It’s not done very consistently though. I’m fine with adding it back. But then we should have it everywhere.

[ronag]

closing for now